From me at the-compiler.org  Fri Oct  4 06:56:56 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Fri, 4 Oct 2013 06:56:56 +0200
Subject: [PATCH] New client/monitor attributes
In-Reply-To: <20130624105326.GJ354@hoth.roethelheim.stw.uni-erlangen.de>
References: <20130620203807.GD26663@lupin>
 <20130624105326.GJ354@hoth.roethelheim.stw.uni-erlangen.de>
Message-ID: <20131004045656.GR17254@lupin>

Heya,

it's been a while, but I finally updated these patches :)
(yay, first real post in the new ml!)

* Thorsten Wi?mann <edu at thorsten-wissmann.de> [2013-06-24 12:53:26 +0200]:
> On Thu, Jun 20, 2013 at 10:38:07PM +0200, Florian Bruhin wrote:
> > The pid attribute will be -1 if the client didn't set it, I'm not sure
> > if this is the best solution, or if I should handle this attribute as
> > a custom string instead, and return an empty string if there is no pid
> > set. Opinions?
> 
> I'd prefer the -1 option (and document it in the manpage)
> 
> You also could add some description of the attributes to the manpage
> (there's already a OBJECTS section[1] describing the attributes)

Done.

> >      HSAttribute attributes[] = {
> > +        ATTRIBUTE_STRING(   "tag",          client->tag->display_name, ATTR_READ_ONLY),
> 
> This looks wrong, because ATTRIBUTE_STRING remembers the address of the
> string you gave it. So in your case this attribute will always give the
> name of the tag the client initially was on (and it should crash as soon
> as the initial tag is removed). I recommend using a custom string
> attribute here. (ATTRIBUTE_STRING only works for strings whose address
> is constant during the livetime of the object or client in this case).

Also done, didn't know about that, seemed logical like I did it :)

I have to apologize about the quality of the previous patches, I was
sending out patches to the ML and was like "oh, that's also finished
and seems to work, let's send it out" without actually really testing
it :-/

Flo

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
May you die in bed at 95, shot by a jealous spouse. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-some-new-client-attributes.patch
Type: text/x-diff
Size: 3349 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131004/f2227e36/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-tag-attribute-to-monitor-object.patch
Type: text/x-diff
Size: 1809 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131004/f2227e36/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131004/f2227e36/attachment.sig>

From edu at thorsten-wissmann.de  Fri Oct  4 10:13:38 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Fri, 4 Oct 2013 10:13:38 +0200
Subject: bring within current tag
In-Reply-To: <8761u9ngaz.wl@tg-x.net>
References: <877gepnkon.wl@tg-x.net>
 <8761u9ngaz.wl@tg-x.net>
Message-ID: <20131004081338.GA4500@hoth.roethelheim.stw.uni-erlangen.de>

Hi,

sorry for the long delay...

On Tue, Sep 10, 2013 at 12:04:36PM +0200, tg wrote:
> >>>>> On Tue, 10 Sep 2013 10:30:00 +0200, Gabor X Toth <*@tg-x.net> said:
> 
> > scoobertron pointed out that the bring command does not move clients
> > within the current tag, the following patch fixes it.

I had to read it at least three times to get it (and check the man page
about the behaviour of the bring command). Thanks, it indeed fixes a bug!

bc43a35 Bring: Move client to current frame within the tag
(I did some commit-message optimizations)

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131004/0c304f0d/attachment.sig>

From edu at thorsten-wissmann.de  Fri Oct  4 10:40:10 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Fri, 4 Oct 2013 10:40:10 +0200
Subject: [PATCH] New client/monitor attributes
In-Reply-To: <20131004045656.GR17254@lupin>
References: <20130620203807.GD26663@lupin>
 <20130624105326.GJ354@hoth.roethelheim.stw.uni-erlangen.de>
 <20131004045656.GR17254@lupin>
Message-ID: <20131004084010.GA8270@hoth.roethelheim.stw.uni-erlangen.de>

Hi,

On Fri, Oct 04, 2013 at 06:56:56AM +0200, Florian Bruhin wrote:
> * Thorsten Wi?mann <edu at thorsten-wissmann.de> [2013-06-24 12:53:26 +0200]:
> > On Thu, Jun 20, 2013 at 10:38:07PM +0200, Florian Bruhin wrote:
> > > The pid attribute will be -1 if the client didn't set it, I'm not sure
> > > if this is the best solution, or if I should handle this attribute as
> > > a custom string instead, and return an empty string if there is no pid
> > > set. Opinions?
> > 
> > I'd prefer the -1 option (and document it in the manpage)
> > 
> > You also could add some description of the attributes to the manpage
> > (there's already a OBJECTS section[1] describing the attributes)
> 
> Done.
> 
> > >      HSAttribute attributes[] = {
> > > +        ATTRIBUTE_STRING(   "tag",          client->tag->display_name, ATTR_READ_ONLY),
> > 
> > This looks wrong, because ATTRIBUTE_STRING remembers the address of the
> > string you gave it. So in your case this attribute will always give the
> > name of the tag the client initially was on (and it should crash as soon
> > as the initial tag is removed). I recommend using a custom string
> > attribute here. (ATTRIBUTE_STRING only works for strings whose address
> > is constant during the livetime of the object or client in this case).
> 
> Also done, didn't know about that, seemed logical like I did it :)
> 
> I have to apologize about the quality of the previous patches, I was
> sending out patches to the ML and was like "oh, that's also finished
> and seems to work, let's send it out" without actually really testing
> it :-/

Looks much better. Thanks for the patch!

> +static void monitor_attr_tag(void* data, GString* output) {
> +    HSMonitor* m = (HSMonitor*) data;
> +    g_string_assign(output, m->tag->display_name->str);
> +}

Sorry, I never documented it yet, but output in this case is the actual
output string, so you should append things to it instead of assigning
them. I already modified your patch, to get this effect:

 $ herbstclient chain , attr monitors.focus.tag , echo
 >                    , attr clients.focus.tag
    mail
    mail

(in the original code, the second attr overwrites the first line and
thus only outputs a single "mail" in my case). It's pushed as:

e44a549 Add tag attribute to monitor object
ce529c0 Add some new client attributes

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131004/a1a9c4a5/attachment.sig>

From me at the-compiler.org  Sun Oct  6 01:40:32 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Sun, 6 Oct 2013 01:40:32 +0200
Subject: [PATCH] Monitor objects per monitor-index
In-Reply-To: <20130624110332.GA5405@hoth.roethelheim.stw.uni-erlangen.de>
References: <20130620204017.GE26663@lupin>
 <20130624110332.GA5405@hoth.roethelheim.stw.uni-erlangen.de>
Message-ID: <20131005234030.GC414@lupin>

* Thorsten Wi?mann <edu at thorsten-wissmann.de> [2013-06-24 13:03:32 +0200]:
> On Thu, Jun 20, 2013 at 10:40:17PM +0200, Florian Bruhin wrote:
> > This patch adds monitor objects to be able to access them by their
> > index if they are unnamed.
> 
> Did you forget to add some hunks in the patch? Because this only adds a
> link when a new monitor is added and never renames them.
> [...]

This should now all be fixed in the attached new patch. Tested it by
adding and removing a few monitors and it works so far. It unlinks and
re-links all id objects when a monitor is removed, as discussed in
IRC.

Also, the second patch uses the new monitor_foreach function for
all_monitors_apply_layout as well.

Florian

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
What this country needs is a good five cent microcomputer. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-objects-monitors.-to-access-monitors-per-id.patch
Type: text/x-diff
Size: 2497 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131006/19e14079/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-monitors_foreach-for-all_monitors_apply_layout.patch
Type: text/x-diff
Size: 752 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131006/19e14079/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131006/19e14079/attachment.sig>

From edu at thorsten-wissmann.de  Sun Oct  6 12:40:15 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Sun, 6 Oct 2013 12:40:15 +0200
Subject: [PATCH] Monitor objects per monitor-index
In-Reply-To: <20131005234030.GC414@lupin>
References: <20130620204017.GE26663@lupin>
 <20130624110332.GA5405@hoth.roethelheim.stw.uni-erlangen.de>
 <20131005234030.GC414@lupin>
Message-ID: <20131006104015.GA16489@hoth.roethelheim.stw.uni-erlangen.de>

Hi Florian,

On Sun, Oct 06, 2013 at 01:40:32AM +0200, Florian Bruhin wrote:
> * Thorsten Wi?mann <edu at thorsten-wissmann.de> [2013-06-24 13:03:32 +0200]:
> > On Thu, Jun 20, 2013 at 10:40:17PM +0200, Florian Bruhin wrote:
> > > This patch adds monitor objects to be able to access them by their
> > > index if they are unnamed.
> > 
> > Did you forget to add some hunks in the patch? Because this only adds a
> > link when a new monitor is added and never renames them.
> > [...]
> 
> This should now all be fixed in the attached new patch. Tested it by
> adding and removing a few monitors and it works so far. It unlinks and
> re-links all id objects when a monitor is removed, as discussed in
> IRC.
> 
> Also, the second patch uses the new monitor_foreach function for
> all_monitors_apply_layout as well.

It doesn't work because of the following:

> +static void monitor_foreach(void (*action)(HSMonitor*)) {
> +    for (int i = 0; i < g_monitors->len; i++) {
> [...]
> +static void monitor_update_id_objects() {
> +    monitor_foreach(monitor_unlink_id_object);
> +    monitor_foreach(monitor_link_id_object);
> +}
> +
> [...]
> @@ -532,6 +558,7 @@ int remove_monitor(int index) {
>      g_string_free(monitor->display_name, true);
>      g_free(monitor);
>      g_array_remove_index(g_monitors, index);
> +    monitor_update_id_objects();

Now, the old monitor object never is removed, because the
foreach(unlink) iterates over all entries of the g_monitors array, so
unlink is not called for monitor as it already has been removed one line
earlier. So monitor_update_id_objects() does not make sense for
removing, because both monitor_foreach() calls iterate over exactly the
same g_monitors state.

The fix for remove_monitor is a little rearrangement:

    g_string_free(monitor->display_name, true);
    monitor_foreach(monitor_unlink_id_object);
    g_array_remove_index(g_monitors, index);
    g_free(monitor);
    monitor_foreach(monitor_link_id_object);

Note that the position of g_free(monitor) does not matter as long as it
called after monitor_unlink_id_object(). (And it is not needed for
add_monitor, so I dropped it).

> From 631cddfe2325e2bbed88fca66d5e746e95188a12 Mon Sep 17 00:00:00 2001
> From: Florian Bruhin <git at the-compiler.org>
> Date: Sun, 6 Oct 2013 00:45:42 +0200
> Subject: [PATCH 2/2] Use monitors_foreach for all_monitors_apply_layout

I changed it to monitor_foreach.

>  void all_monitors_apply_layout() {
> -    for (int i = 0; i < g_monitors->len; i++) {
> -        HSMonitor* m = monitor_with_index(i);
> -        monitor_apply_layout(m);
> -    }
> +    monitor_foreach(monitor_apply_layout);
>  }

Well spotted! All in all, it is much less code than I expected. Good
Work!

After the named modifications[1] I pushed it as:

b7d1d6d Use monitor_foreach for all_monitors_apply_layout
6006395 Add objects monitors.* to access monitors per id

Regards,
Thorsten

[1] If you have problems with me modifing your patch and commiting it
with your name, let me know.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131006/6231c85d/attachment.sig>

From me at the-compiler.org  Sun Oct  6 13:28:09 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Sun, 6 Oct 2013 13:28:09 +0200
Subject: [PATCH] Monitor objects per monitor-index
In-Reply-To: <20131006104015.GA16489@hoth.roethelheim.stw.uni-erlangen.de>
References: <20130620204017.GE26663@lupin>
 <20130624110332.GA5405@hoth.roethelheim.stw.uni-erlangen.de>
 <20131005234030.GC414@lupin>
 <20131006104015.GA16489@hoth.roethelheim.stw.uni-erlangen.de>
Message-ID: <20131006112808.GE414@lupin>

* Thorsten Wi?mann <edu at thorsten-wissmann.de> [2013-10-06 12:40:15 +0200]:
> Hi Florian,

Hi,

by the way, any reason you always use [g]roup reply instead of [L]ist
reply? No need to Cc me because I'm already on the list.

Doesn't matter much because Mailman avoids duplicates, but I usually
only reply to the list.

> Now, the old monitor object never is removed, because the
> foreach(unlink) iterates over all entries of the g_monitors array, so
> unlink is not called for monitor as it already has been removed one line
> earlier. So monitor_update_id_objects() does not make sense for
> removing, because both monitor_foreach() calls iterate over exactly the
> same g_monitors state.

Huh, I think I thought about "wait, when do I need to do that so
g_monitors is right". Seems I failed :D

> Well spotted! All in all, it is much less code than I expected. Good
> Work!

Thanks :) Yeah, also wasn't as hard as I expected.

Now two local branches left, maximizing and frame-objects :)

> [1] If you have problems with me modifing your patch and commiting it
> with your name, let me know.

Not at all, I trust your code more than mine :D

Florian

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
<liiwi> so, what's the official way to get buildd to retry a package? prod it 
with a stick? <Joey> prod neuro <liiwi> with a stick? <Joey> yes. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131006/03d475e6/attachment.sig>

From me at the-compiler.org  Tue Oct  8 22:14:25 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Tue, 8 Oct 2013 22:14:25 +0200
Subject: [PATCH] Simple script fixes for autostart
Message-ID: <20131008201425.GM414@lupin>

Hi,

I noticed I did ignore the autostart script when doing my scripts
cleanup foo. This patch changes the following in the autostart script:

 - Uses "foo()" instead of "function foo()" which is more portable

 - Uses lowercase variables because all-uppercase variables are by
   convention used for environmental variables

 - Replaces some double-blank-lines by single ones, just because.

Flo

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
I'm not laughing with you, I'm laughing at you. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simple-script-fixes-in-autostart.patch
Type: text/x-diff
Size: 2330 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/b0dba3f8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/b0dba3f8/attachment.sig>

From edu at thorsten-wissmann.de  Tue Oct  8 23:46:56 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Tue, 8 Oct 2013 23:46:56 +0200
Subject: [PATCH] Fix date display in panel
In-Reply-To: <20131008200817.GL414@lupin>
References: <20131008200817.GL414@lupin>
Message-ID: <20131008214656.GA943@hoth.roethelheim.stw.uni-erlangen.de>

On Tue, Oct 08, 2013 at 10:08:17PM +0200, Florian Bruhin wrote:
> with my scripts cleanup I accidentally fsckd up the date/time display
> in the panel. Seems like nobody noticed :P
> 
> The problem is the 'read -ra' only accepts tabs as field delimiters
> (so somebody could have a tag with a space in it or whatever), but the
> date line still used a space.

I indeed never noticed because even in Xephyr with the default
autostart, my personal panel.sh from XDG_HOME is used... Thanks for
fixing it:

d2cdb93 Fix date display in panel

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/0f0b4c03/attachment.sig>

From edu at thorsten-wissmann.de  Tue Oct  8 23:49:21 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Tue, 8 Oct 2013 23:49:21 +0200
Subject: [PATCH] Simple script fixes for autostart
In-Reply-To: <20131008201425.GM414@lupin>
References: <20131008201425.GM414@lupin>
Message-ID: <20131008214921.GB943@hoth.roethelheim.stw.uni-erlangen.de>

Hi Florian,

On Tue, Oct 08, 2013 at 10:14:25PM +0200, Florian Bruhin wrote:
> I noticed I did ignore the autostart script when doing my scripts
> cleanup foo. This patch changes the following in the autostart script:
> 
>  - Uses "foo()" instead of "function foo()" which is more portable
> 
>  - Uses lowercase variables because all-uppercase variables are by
>    convention used for environmental variables
> 
>  - Replaces some double-blank-lines by single ones, just because.

Okidokely:

80a8e17 Simple script fixes in autostart

Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/fd050663/attachment.sig>

From me at the-compiler.org  Tue Oct  8 22:08:17 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Tue, 8 Oct 2013 22:08:17 +0200
Subject: [PATCH] Fix date display in panel
Message-ID: <20131008200817.GL414@lupin>

Heya,

with my scripts cleanup I accidentally fsckd up the date/time display
in the panel. Seems like nobody noticed :P

The problem is the 'read -ra' only accepts tabs as field delimiters
(so somebody could have a tag with a space in it or whatever), but the
date line still used a space.

The attached patch fixes this by using a tab there as well.

Sorry for that!

Florian

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
At many levels, Perl is a "diagonal" language. -- Larry Wall in 
<199709021854.LAA12794 at wall.org> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-date-display-in-panel.patch
Type: text/x-diff
Size: 739 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/79b5b554/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131008/79b5b554/attachment.sig>

From me at the-compiler.org  Sun Oct 13 22:03:34 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Sun, 13 Oct 2013 22:03:34 +0200
Subject: [PATCH] Fix spelling errors in comments (s/leave/leaf)
Message-ID: <20131013200333.GK18670@lupin>

Just noticed that while reviewing my frame object code.

I think you mean "leaf" (Blatt) and not "leave" (verlassen)

Flo

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
Your manuscript is both good and original, but the part that is good is not 
original and the part that is original is not good. -- Samuel Johnson 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-comment-spelling-leave-leaf.patch
Type: text/x-diff
Size: 2177 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131013/078116d2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131013/078116d2/attachment.sig>

From edu at thorsten-wissmann.de  Mon Oct 14 02:04:45 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Mon, 14 Oct 2013 02:04:45 +0200
Subject: [PATCH] Fix spelling errors in comments (s/leave/leaf)
In-Reply-To: <20131013200333.GK18670@lupin>
References: <20131013200333.GK18670@lupin>
Message-ID: <20131014000444.GA23407@hoth.roethelheim.stw.uni-erlangen.de>

On Sun, Oct 13, 2013 at 10:03:34PM +0200, Florian Bruhin wrote:
> Just noticed that while reviewing my frame object code.
> 
> I think you mean "leaf" (Blatt) and not "leave" (verlassen)

Yeah, the singular of leaves ;)

5763268 Fix comment spelling: leave -> leaf

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131014/b8780c07/attachment.sig>

From mono at posteo.de  Sun Oct 20 10:48:08 2013
From: mono at posteo.de (Mono)
Date: Sun, 20 Oct 2013 10:48:08 +0200
Subject: AUR package
Message-ID: <20131020084808.GA7740@moosbart>

Hallo,

PKGBUILD of the herbstluftwm package in Arch User Repository could be improved a little, no need to have git in makedepends.

btw, I'd vote for herbstluftwm again. It's the only wm I use at work and home for about, well, a few months. thanks!

best regards,
Mono
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_git_from_makedepends.patch
Type: text/x-diff
Size: 306 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131020/5a28e871/attachment.bin>

From me at the-compiler.org  Mon Oct 21 07:12:03 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Mon, 21 Oct 2013 07:12:03 +0200
Subject: [PATCH] Fix prototype name
Message-ID: <20131021051202.GH18956@lupin>

The attached patch fixes the different name of the same function in
the .c and .h file, like discussed in IRC yesterday ;)

Flo

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
When it is incorrect, it is, at least *authoritatively* incorrect. -- 
Hitchiker's Guide To The Galaxy 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-prototype-name.patch
Type: text/x-diff
Size: 942 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131021/df90cb51/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131021/df90cb51/attachment.sig>

From edu at thorsten-wissmann.de  Mon Oct 21 14:20:10 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Mon, 21 Oct 2013 14:20:10 +0200
Subject: AUR package
In-Reply-To: <20131020084808.GA7740@moosbart>
References: <20131020084808.GA7740@moosbart>
Message-ID: <20131021122009.GA4405@hoth.roethelheim.stw.uni-erlangen.de>

Hi Mono,

On Sun, Oct 20, 2013 at 10:48:08AM +0200, Mono wrote:
> PKGBUILD of the herbstluftwm package in Arch User Repository could be
> improved a little, no need to have git in makedepends.

You're right. I just updated it.

> btw, I'd vote for herbstluftwm again. It's the only wm I use at work
> and home for about, well, a few months. thanks!

Thanks :)

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131021/aa6a1b70/attachment.sig>

From edu at thorsten-wissmann.de  Mon Oct 21 14:22:00 2013
From: edu at thorsten-wissmann.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Mon, 21 Oct 2013 14:22:00 +0200
Subject: [PATCH] Fix prototype name
In-Reply-To: <20131021051202.GH18956@lupin>
References: <20131021051202.GH18956@lupin>
Message-ID: <20131021122200.GB4405@hoth.roethelheim.stw.uni-erlangen.de>

Hi Florian,

On Mon, Oct 21, 2013 at 07:12:03AM +0200, Florian Bruhin wrote:
> The attached patch fixes the different name of the same function in
> the .c and .h file, like discussed in IRC yesterday ;)

96d95b9 fix prototype name

Regards,
Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 230 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131021/b8d8302d/attachment.sig>

From me at the-compiler.org  Tue Oct 22 07:02:22 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Tue, 22 Oct 2013 07:02:22 +0200
Subject: [PATCH] Synchronize .c and .h files
Message-ID: <20131022050222.GP18956@lupin>

See commit message for details :)

One of these more usless commits, but it bothered me and I wanted to
check if there are other functions named differently in .c and .h.

Generated by doing:

$ for f in *.c; do grep '^\([^ ]\+ \)\+[^ ]\+(.*) {' "$f" | \
grep -v '^static' | sed 's/ {$/;/' | sort > "$f".fun; done

$ for f in *.h; do grep '(.*);' "$f" | sort > "$f".fun; done

And then comparing each foo.[ch].fun with vimdiff and doing some
filtering by hand. (Yes, it's quick & dirty)

Florian

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
"In the long run, every program becomes rococo, and then rubble." -- Alan 
Perlis 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Synchronize-.c-and-.h-files.patch
Type: text/x-diff
Size: 12938 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131022/4fa1e0cf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131022/4fa1e0cf/attachment.sig>

From re06huxa at cip.cs.fau.de  Thu Oct 24 17:41:43 2013
From: re06huxa at cip.cs.fau.de (Thorsten =?iso-8859-1?Q?Wi=DFmann?=)
Date: Thu, 24 Oct 2013 17:41:43 +0200
Subject: [PATCH] Synchronize .c and .h files
In-Reply-To: <20131022050222.GP18956@lupin>
References: <20131022050222.GP18956@lupin>
Message-ID: <20131024154143.GA14986@stud.informatik.uni-erlangen.de>

On Tue, Oct 22, 2013 at 07:02:22AM +0200, Florian Bruhin wrote:
> See commit message for details :)
> 
> One of these more usless commits, but it bothered me and I wanted to
> check if there are other functions named differently in .c and .h.

Thanks! Why not :)

b07f5eb Synchronize .c and .h files.

Regards,
Thorsten


From me at the-compiler.org  Tue Oct 29 18:53:10 2013
From: me at the-compiler.org (Florian Bruhin)
Date: Tue, 29 Oct 2013 18:53:10 +0100
Subject: [PATCH] add comments to panel.sh
Message-ID: <20131029175309.GA327@lupin>

This patch aims to make panel.sh a bit easier to understand.
I had a while until I got the concept, and I've also seen people in
IRC who don't get it :P

Florian

-- 
() ascii ribbon campaign - stop html mail    www.asciiribbon.org
/\ www.the-compiler.org  | I love long mails http://email.is-not-s.ms/
He who invents adages for others to peruse takes along rowboat when going on 
cruise. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-comments-to-panel.sh.patch
Type: text/x-diff
Size: 3104 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131029/44fd6a9d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/hlwm/attachments/20131029/44fd6a9d/attachment.sig>